-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify ENS names #9178
Verify ENS names #9178
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (47)
|
@@ -55,6 +55,7 @@ | |||
;;TODO not used anywhere? | |||
"shhext_deleteChat" {} | |||
"shhext_saveContact" {} | |||
"shhext_verifyENSNames" {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this would entirely be done on go side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, eventually maybe, but we are not parsing messages yet in status-go (we only do for the console client, but otherwise we would be parsing them twice, as we still have to port some of the handling, so it's disabled in status-react), and the ens name is inside the content
field (or contact-request).
So status-react will parse the message and send the usernames to be verified to status-go (note that even if we did resolve them in status-go, it would be asynchronous, as resolving username can take up to 1,2 seconds, so we would pass the messages immediately and send another signal once resolved, so from a user perspective it would be asynchronous in both cases)
cf2b2ef
to
a87bde5
Compare
a87bde5
to
4740308
Compare
7cfe84f
to
6ccfafb
Compare
(let [actual (message/receive-whisper-messages {:db {}} nil messages sig)] | ||
(testing "it add an fx for the message" | ||
(is (:chat-received-message/add-fx actual)))))) | ||
#_(deftest receive-whisper-messages-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh leftover, forgot to uncomment it, thanks
62% of end-end tests have passed
Failed tests (37)Click to expand
Passed tests (61)Click to expand |
6ccfafb
to
bd51f73
Compare
bd51f73
to
eff12db
Compare
340b803
to
3123070
Compare
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (100)Click to expand
|
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (100)Click to expand
|
@churik would it be possible to disable this test? I can't merge status-go as we are still waiting to fix the geth 1.9 upgrade, but I would like to merge this code in so I don't have to rebase, i will re-enable the test once we merge status-go (and so we can verify the ens name), would that be ok? |
@cammellos |
@churik yes, until we merge 1.9 and include the feature for verifying ens names (current develop shows ens name even if they are not verified, so arguably is already broken :) ) |
@cammellos mind my commit when squashing. Thanks! |
Thanks! |
87a1eb2
to
8885f9d
Compare
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (100)Click to expand
|
Merging this in, the feature is disabled currently until 1.9 issues are fixed, but at least I won't have to constantly rebase, I will enable once it sorted. |
This commits verifies ens names when new messages or contact requests come through. A batch of ens names is sent to status-go which will then verifying them and the result will be passed back in a callback to status-react. Also temporary skipped test_ens_in_public_chat until we merge the ENS code (blocked currently by 1.9 upgrade) Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
8885f9d
to
57b1722
Compare
This commits verifies ens names when new messages or contact requests come through.
A batch of ens names is sent to status-go which will then verifying them
and the result will be passed back in a callback to status-react.
Currently this can only be partially tested as status-im/status-go#1641 is unresolved, so very few messages comes through.
status: ready